[MPlayer-dev-eng] [PATCH] vo_kva

[KO Myung-Hun]

Hi/2.

Georgi Petrov wrote:
> One possible flaw I see is that flip_page() calls imgDisplay(), which
> copies the frame. The frame is supposed to be already copied to some
> kind of offscreen buffer and flip_page() should only "flip" it and set
> it active. I made exactly the same mistake with my driver. The reason
> for this is that flip_page() is issued in the right time for each
> frame and is supposed to return quick in order to have "fluent" video
> experience (understand no jerkyness). The actual "frame upload" code
> should be placed in draw_slice() and after VOCTRL_DRAW_IMAGE, so when
> few parts of the second later a flip_page() is called, the "flip" can
> happen in an instant. The strange thing is that you copy in both
> draw_slice AND in flip_page()... How does this make sense?
>
> I can be mistaken, of course.
>   

flip_page() transfers the contents of the frame of the internal buffer 
to the video buffer allocated by video hw and displays them. But 
draw_slice() copys the contents to the internal buffer.

And as you see, kvaLockBuffer() allocate a video buffer and 
kvaUnlockBuffer() display the contents of the video buffer. So I cannot 
use a video buffer in draw_slice().

Any problems ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr