[MPlayer-dev-eng] [PATCH] restructure fmt-conversion.h and use it in vd_ffmpeg.c

[Reimar Döffinger]

On Sat, Feb 14, 2009 at 04:42:03PM +0200, Uoti Urpala wrote:
> I didn't look carefully at the patch, but happened to notice this
> obviously broken part:
> > +enum PixelFormat imgfmt2pixfmt(int fmt);
> > +int imgfmt2pixfmt(enum PixelFormat pix_fmt);
> Looking at the .c file part I guess the second should be pixfmt2imgfmt.
> Also the .c file should include the corresponding .h.

Amazing how considering something trivial invites (trivial) bugs.

> I think a subdirectory would be a better location for files like this,
> though libmpcodecs/ is itself a bit too large.

The name itself is no good either. I think this should have been in
img_format all along, but for now lazyness wins and I'll leave it as it
is. If there is a huge outcry and everyone wants it moved that is done
in no time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fmtconv.diff
Type: text/x-diff
Size: 8473 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090214/02945a36/attachment.diff>