[MPlayer-dev-eng] [PATCH] restructure fmt-conversion.h and use it in vd_ffmpeg.c

[Uoti Urpala]

On Sat, 2009-02-14 at 15:15 +0100, Reimar Döffinger wrote:
> On Sat, Feb 14, 2009 at 01:04:15PM +0100, Diego Biurrun wrote:
> > > --- fmt-conversion.c	(revision 0)
> > > +++ fmt-conversion.c	(revision 0)
> > > @@ -0,0 +1,76 @@
> > > +#include "mp_msg.h"
> > > +#include "libavutil/avutil.h"
> > > +#include "libmpcodecs/img_format.h"
> > 
> > ...please add our standard license header to new files.
> 
> copied from vo_gl, I hope that is not one you forgot to fix ;-)

I didn't look carefully at the patch, but happened to notice this
obviously broken part:
> +enum PixelFormat imgfmt2pixfmt(int fmt);
> +int imgfmt2pixfmt(enum PixelFormat pix_fmt);
Looking at the .c file part I guess the second should be pixfmt2imgfmt.
Also the .c file should include the corresponding .h.
I think a subdirectory would be a better location for files like this,
though libmpcodecs/ is itself a bit too large.