[MPlayer-dev-eng] [PATCH] factor out panscan etc. calculation from xv, xvmc and direct3d

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Feb 12 19:04:29 CET 2009


On Thu, Feb 12, 2009 at 07:28:08PM +0200, Ivan Kalvachev wrote:
> I can only complain from the fact that resize()
> uses and modifies globals, and it is not obvious what it changes,
> but it seems very common in x11_common.

Well, currently the rule is "resize changes whatever needs to be changed
after the window was resized or panscan changed and fixes up for any
side effects", so it hopefully is not that important to know what it
actually changes.
I don't mind changing the prototype if you have something in mind that
you consider significantly better - I came to the conclusion it would
only bloat the places where it is called, which is a kind of code
duplication, too. So I decided I had better things to do than think
about that ;-)

> I'm ok with the patch.

Great, applied.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list