[MPlayer-dev-eng] [PATCH] factor out panscan etc. calculation from xv, xvmc and direct3d

Ivan Kalvachev ikalvachev at gmail.com
Thu Feb 12 18:28:08 CET 2009


On 2/12/09, Georgi Petrov <gogothebee at gmail.com> wrote:
>> This one uses a struct...
>
> I like it much better. IMHO this is good enough. It makes my driver
> more beautiful as well - especially the 1:1 mapping of
> top/bottom/left/right :)

Same.

I can only complain from the fact that resize()
uses and modifies globals, and it is not obvious what it changes,
but it seems very common in x11_common.

I'm ok with the patch.



More information about the MPlayer-dev-eng mailing list