[MPlayer-dev-eng] [PATCH] Fix warnings from missing includes

Diego Biurrun diego at biurrun.de
Wed Dec 9 18:31:08 CET 2009


On Thu, Dec 03, 2009 at 10:54:04AM +0100, Peter Hjalmarsson wrote:
>  * QA Notice: Package has poor programming practices which may compile
>  *            fine but exhibit random runtime failures.
>  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
>  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
>  * tremor/misc.h:188: warning: implicit declaration of function 'abs'
>  * tremor/misc.h:188: warning: implicit declaration of function 'abs'
>  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
>  * tremor/misc.h:188: warning: implicit declaration of function 'abs'
>  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> 
> These warnings are because of two missing includes, the attached patch
> fixes these.

We generally try to avoid patching internal copies of external
libraries.  Then again, this is trivial enough to just apply anyway.
Thoughts?

Diego



More information about the MPlayer-dev-eng mailing list