[MPlayer-dev-eng] [PATCH] Fix warnings from missing includes

Wed Dec 9 18:41:03 CET 2009

On Wednesday, 09 December 2009 at 18:31, Diego Biurrun wrote:
> On Thu, Dec 03, 2009 at 10:54:04AM +0100, Peter Hjalmarsson wrote:
> >  * QA Notice: Package has poor programming practices which may compile
> >  *            fine but exhibit random runtime failures.
> >  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> >  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> >  * tremor/misc.h:188: warning: implicit declaration of function 'abs'
> >  * tremor/misc.h:188: warning: implicit declaration of function 'abs'
> >  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> >  * tremor/misc.h:188: warning: implicit declaration of function 'abs'
> >  * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> > 
> > These warnings are because of two missing includes, the attached patch
> > fixes these.
> 
> We generally try to avoid patching internal copies of external
> libraries.  Then again, this is trivial enough to just apply anyway.
> Thoughts?

I used to have a similar patch in my tree, I'll look at it and report
back when I get home.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | RPMFusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan