[MPlayer-dev-eng] [PATCH] fix undefined reference to `palette***

[Andrew Savchenko]

Hi,

On Sunday 26 October 2008 16:26, Michael Niedermayer wrote:
> On Fri, Oct 24, 2008 at 10:37:23PM +0200, Diego Biurrun wrote:
> > On Thu, Oct 23, 2008 at 10:56:19PM +0200, Guillaume POIRIER 
wrote:
> > > Attached patch fixes undefined references due to the recent
> > > changes in swscale.
> > >
> > > I'm not quite so sure that it's correct, but on the samples
> > > I had on my machine, it seemed alright.
> > >
> > > Please have a look at it.
> >
> > Michael?  Compilation is currently broken...
>
> I belive the change is wrong and the code will fail on at least
> some of big/little rgb/bgr32/24

It was reported this patch seems to works fine on x86_64 and x86. 
At least I have no problems on my x86 box yet; maybe I'll 
encounter them later.

> besides this, the true problem was caused by the direct use of
> the rgb2rgb code. Had the swscaler been used directly no problem
> would have happened.

If this code is broken, please be kind to provide samples to check 
this or the way to generate them. If you can fix this code, this 
will be highly appreciated. *But* having broken, impossible to 
compile code in prefer of possibly broken one is a really bad 
idea, especially in the project claimed itself as "svn stable"; 
IOW when it is highly recommended for users to use svn head 
instead of releases, any svn revision should be at least 
compilable and any possible fatal problems with build process 
should be fixed ASAP.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081026/d3f27867/attachment.pgp>