[MPlayer-dev-eng] [PATCH] fix undefined reference to `palette***

[Michael Niedermayer]

On Fri, Oct 24, 2008 at 10:37:23PM +0200, Diego Biurrun wrote:
> On Thu, Oct 23, 2008 at 10:56:19PM +0200, Guillaume POIRIER wrote:
> > 
> > Attached patch fixes undefined references due to the recent changes in swscale.
> > 
> > I'm not quite so sure that it's correct, but on the samples I had on
> > my machine, it seemed alright.
> > 
> > Please have a look at it.
> 
> Michael?  Compilation is currently broken...

I belive the change is wrong and the code will fail on at least some of
big/little rgb/bgr32/24

besides this, the true problem was caused by the direct use of the rgb2rgb
code. Had the swscaler been used directly no problem would have happened.

Also IMHO these functions are not supposed to be public API, also rgb2rgb.h
should not be installed as libswscale/Makefile is doing, i am not sure why
it is installed currently. IMHO this is wrong ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081026/1026a12c/attachment.pgp>