[MPlayer-dev-eng] [PATCH] fix vo_xvidix x and y offset calculation

[Sascha Sommer]

Hi,

On Mittwoch, 15. Oktober 2008, Reimar Döffinger wrote:
> On Wed, Oct 15, 2008 at 08:51:01PM +0200, Sascha Sommer wrote:
> > currently vidix seems to be broken. Attached patch fixes it for me.
> > Somehow the xinerama screen seems to be set to the default -1
> > what then adds random values to the x and y offsets leading to a broken
> > picture.
> >
> > Ok to commit?
>
> Well, I am not exactly sure WTF that code is exactly supposed to do, but
> I think
> 1) it misuses xinerama_screen variable which is supposed to contain the
> commandline option to save its internal state
> 2) you probably can do this much simpler by replacing the whole code
> with
>
> > update_xinerama_info();
> > drwcX -= xinerama_x;
> > drwcY -= xinerama_y;
>

New patch attached.

> There probably is a lot more code that is (no longer) necessary in there
> but I feel somewhat low on motivation to work on something that
> unfortunately is likely to have no future at all.
>

I'm also not very motivated but xvidix is still a nice to have feature for 
those ancient machines where no xv support is available.

Regards

Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_xvidix_try2.patch
Type: text/x-diff
Size: 1552 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081015/898cc9d6/attachment.patch>