[MPlayer-dev-eng] [PATCH] fix vo_xvidix x and y offset calculation

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Oct 15 21:07:17 CEST 2008


On Wed, Oct 15, 2008 at 08:51:01PM +0200, Sascha Sommer wrote:
> currently vidix seems to be broken. Attached patch fixes it for me.
> Somehow the xinerama screen seems to be set to the default -1
> what then adds random values to the x and y offsets leading to a broken 
> picture.
> 
> Ok to commit?

Well, I am not exactly sure WTF that code is exactly supposed to do, but
I think
1) it misuses xinerama_screen variable which is supposed to contain the
commandline option to save its internal state
2) you probably can do this much simpler by replacing the whole code
with
> update_xinerama_info();
> drwcX -= xinerama_x;
> drwcY -= xinerama_y;

There probably is a lot more code that is (no longer) necessary in there
but I feel somewhat low on motivation to work on something that
unfortunately is likely to have no future at all.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list