[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Reimar Döffinger]

On Tue, Nov 18, 2008 at 01:30:10AM +0200, Georgi Petrov wrote:
> Reverting back to D3DSWAPEFFECT_COPY :(
> With D3D Debug engine I see flashing bars on the top/bottom areas in
> fullscreen, which are not updated during StretchRect actually and the
> Debug engine sets random data just to remind me that this is not
> supposed to be like that. The performance difference was REALLY minor
> anyways...

Well, I was about to reply to your other mail: The other setting is the
correct one, but you should call the clear function after each present,
at least when you apply aspect scaling. This is exactly what -vo gl does
(OpenGL does not even have the option of keeping the previous contents
IIRC).
If the backbuffer is on a dedicated graphics card, clearing should
practically take no time at all, and even with copy you _will_ have to
clear as soon as you implement the OSD, since the OSD will be drawn into
the black bars and if you just use D3DSWAPEFFECT_COPY will stay there
forever.
Btw. could you just replace your own aspect handling code by the one I
proposed? IMO that is all that needs to be done before committing an
initial version.

Greetings,
Reimar Döffinger