[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Georgi Petrov]

> Rerun configure and get GNU Make 3.81.

Didn't help.

>
>> --- libvo/vo_direct3d.c       (revision 0)
>> +++ libvo/vo_direct3d.c       (revision 0)
>> @@ -0,0 +1,682 @@
>> +#include "mp_msg.h"
>> +#include "w32_common.h" /* Common code shared with at least vo_gl, which makes
>> +                         * my life easier. Big thanks to Reimar Doeffinger.
>> +                         * Documentation is present in DOCS\tech\w32_common.txt
>> +                         */
>
> I'm sure Reimar is happy to hear this, but now that he knows I think the
> comment is unnecessary.
>

Fixed :(

>> +/*
>> + * Link essential libvo functions: preinit, config, control, draw_frame,
>> + * draw_slice, draw_osd, flip_page, check_events, uninit and
>> + * the strcuture info. Only there functions are related to libvo.
>
> strUCture
>
> I don't understand "Only there functions are related to libvo.".
>

Fixed.

>> +/*
>> + * Function declarations
>> + */
>> +
>> +int D3DConfigure (void);
>
> Forward declarations are ugly.

Well, fixed.

>
>> --- configure (revision 27942)
>> +++ configure (working copy)
>> @@ -8374,6 +8399,7 @@
>>  $_def_directfb
>>  $_def_directfb_version
>> +$_def_direct3d
>>  $_def_directx
>
> This is not alphabetical order.

Well, stupid me. Fixed.

>
>> --- DOCS/tech/w32_common.txt  (revision 0)
>> +++ DOCS/tech/w32_common.txt  (revision 0)
>> @@ -0,0 +1,112 @@
>> +Documentation for common Windows libvo window-handling code.
>
> This sounds like a great idea, but I think it would be better done as
> Doxygen comments in the code.

Fixed. You should take a look.

That's it, I attach the updated patch.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: direct3d.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081117/9d1ee294/attachment.txt>