[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Diego Biurrun]

On Sun, Nov 16, 2008 at 10:04:10PM +0200, Georgi Petrov wrote:
> 
> I can't even compile the latest SVN now. It fails with:
> 
> make[1]: Entering directory `/devel/libavcodec'
> make[1]: *** No rule to make target `i386/fft_mmx.o', needed by `libavcodec.a'

Rerun configure and get GNU Make 3.81.

> --- libvo/vo_direct3d.c	(revision 0)
> +++ libvo/vo_direct3d.c	(revision 0)
> @@ -0,0 +1,682 @@
> +#include "mp_msg.h"
> +#include "w32_common.h" /* Common code shared with at least vo_gl, which makes
> +                         * my life easier. Big thanks to Reimar Doeffinger.
> +                         * Documentation is present in DOCS\tech\w32_common.txt
> +                         */

I'm sure Reimar is happy to hear this, but now that he knows I think the
comment is unnecessary.

> +/*
> + * Link essential libvo functions: preinit, config, control, draw_frame,
> + * draw_slice, draw_osd, flip_page, check_events, uninit and
> + * the strcuture info. Only there functions are related to libvo.

strUCture

I don't understand "Only there functions are related to libvo.".

> +/*
> + * Function declarations
> + */
> +
> +int D3DConfigure (void);

Forward declarations are ugly.

> --- configure	(revision 27942)
> +++ configure	(working copy)
> @@ -8374,6 +8399,7 @@
>  $_def_directfb
>  $_def_directfb_version
> +$_def_direct3d
>  $_def_directx

This is not alphabetical order.

> --- DOCS/tech/w32_common.txt	(revision 0)
> +++ DOCS/tech/w32_common.txt	(revision 0)
> @@ -0,0 +1,112 @@
> +Documentation for common Windows libvo window-handling code.

This sounds like a great idea, but I think it would be better done as
Doxygen comments in the code.

Diego