[MPlayer-dev-eng] [PATCH] yasm support

[Andrew Savchenko]

Hi,

On Thursday 06 November 2008 13:32, Diego Biurrun wrote:
[...]
> > --- configure.orig	2008-11-06 07:06:20.000000000 +0300
> > +++ configure	2008-11-06 10:31:48.000000000 +0300
>
> You don't use Subversion?

I do, but not svn diff. Just an old habit. Fixed.

> > @@ -408,6 +421,7 @@
> >    --as=ASSEMBLER         assembler to build MPlayer [as]
> > +  --yasm=YASM            yasm assembler to build MPlayer
> > [yasm]
>
> Yasm

I suppose you mean "Yasm assembler to ...".

> > @@ -2385,6 +2403,43 @@
> >
> > +echocheck "yasm"
> > +if test -z "$YASMFLAGS" ; then
> > +    [...]
> > +else
> > +    _warn_CFLAGS=yes
> > +fi
> > +
> > +if test $_yasm ; then
> > +  [...]
> > +fi
>
> inconsistent indentation, use two spaces

Done.

> > +  # check for mmx in order to enable FFT_MMX
>
> MMX

This comment will be purged due to further changes.

> > +  _def_makefile_yasm='HAVE_YASM=yes'
>
> You do not need _def_makefile_yasm...
>
> > +  test "$_mmx" == "yes" &&
> > _def_makefile_fft_mmx="CONFIG_FFT_MMX=yes"
>
> ... nor _def_makefile_fft_mmx.
>
> > @@ -7839,6 +7896,7 @@
> >  `echo $_cpuexts | tr '[a-z] ' '[A-Z]\n' | sed
> > +$_def_makefile_yasm
>
> This belongs in the FFmpeg section.
>
> > @@ -7983,6 +8041,7 @@
> >
> >  # Some FFmpeg codecs depend on these. Enable them
> > unconditionally for now. CONFIG_FFT=yes
> > +$_def_makefile_fft_mmx
>
> Just write the definition here, do not use a variable.

OK

> > --- common.mak.orig	2008-05-12 21:50:30.000000000 +0400
> > +++ common.mak	2008-11-06 09:57:20.000000000 +0300
> > @@ -80,6 +80,12 @@
>
> Syncing this file from FFmpeg should be done separately.

Full sync is done. (In the first version it was only partial.) Of 
course, this commit should be done in first place, otherwise 
compilation will be broken in between.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: common.mak.patch
Type: text/x-diff
Size: 2463 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081107/15cce3b7/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yasm.patch
Type: text/x-diff
Size: 4210 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081107/15cce3b7/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081107/15cce3b7/attachment.pgp>