[MPlayer-dev-eng] [PATCH] yasm support

[Diego Biurrun]

On Thu, Nov 06, 2008 at 11:00:10AM +0300, Andrew Savchenko wrote:
> 
> the following patch adds yasm support to the build system.
> In particular, this allows to use a benefit from mmx-like 
> optimizations in libavcodec/fft.c
> 
> Comments?

> --- configure.orig	2008-11-06 07:06:20.000000000 +0300
> +++ configure	2008-11-06 10:31:48.000000000 +0300

You don't use Subversion?

> @@ -408,6 +421,7 @@
>    --as=ASSEMBLER         assembler to build MPlayer [as]
> +  --yasm=YASM            yasm assembler to build MPlayer [yasm]

Yasm

> @@ -2385,6 +2403,43 @@
>  
> +echocheck "yasm"
> +if test -z "$YASMFLAGS" ; then
> +    [...]
> +else
> +    _warn_CFLAGS=yes
> +fi
> +
> +if test $_yasm ; then
> +  [...]
> +fi

inconsistent indentation, use two spaces

> +  # check for mmx in order to enable FFT_MMX

MMX

> +  _def_makefile_yasm='HAVE_YASM=yes'

You do not need _def_makefile_yasm...

> +  test "$_mmx" == "yes" && _def_makefile_fft_mmx="CONFIG_FFT_MMX=yes"

... nor _def_makefile_fft_mmx.

> @@ -7839,6 +7896,7 @@
>  `echo $_cpuexts | tr '[a-z] ' '[A-Z]\n' | sed 's/^/HAVE_/;s/$/=yes/'`
> +$_def_makefile_yasm
 
This belongs in the FFmpeg section.

> @@ -7983,6 +8041,7 @@
>  
>  # Some FFmpeg codecs depend on these. Enable them unconditionally for now.
>  CONFIG_FFT=yes
> +$_def_makefile_fft_mmx

Just write the definition here, do not use a variable.

> --- common.mak.orig	2008-05-12 21:50:30.000000000 +0400
> +++ common.mak	2008-11-06 09:57:20.000000000 +0300
> @@ -80,6 +80,12 @@

Syncing this file from FFmpeg should be done separately.

Diego