[MPlayer-dev-eng] [PATCH] get rid of "define RECURSIVE_RULE" in Makefile

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu May 22 17:21:41 CEST 2008


Hello,
since it causes troubles to no end with standard make versions (in my
case the MinGW make completely ignores the rules, and the linux one can
not do parallel make), I propose attached patch.
Maybe there is some subtle reason why it is not as good, then say so.
Otherwise I will apply in a few days, because I'm really not in the mood
to hut down a working make version for all of my PCs/OSs.

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: Makefile
===================================================================
--- Makefile	(revision 26853)
+++ Makefile	(working copy)
@@ -719,12 +719,10 @@
 dep depend: $(DEPS)
 	for part in $(PARTS); do $(MAKE) -C $$part depend; done
 
-define RECURSIVE_RULE
-$(part)/$(part).a: recurse
-	$(MAKE) -C $(part)
-endef
+ALLPARTLIBS = $(foreach part, $(PARTS), $(part)/$(part).a)
 
-$(foreach part,$(PARTS),$(eval $(RECURSIVE_RULE)))
+$(ALLPARTLIBS): recurse
+	$(MAKE) -C $(@D)
 
 mplayer$(EXESUF): $(MPLAYER_DEPS)
 	$(CC) -o $@ $^ $(LDFLAGS_MPLAYER)


More information about the MPlayer-dev-eng mailing list