[MPlayer-dev-eng] [PATCH] get rid of "define RECURSIVE_RULE" in Makefile

Uoti Urpala uoti.urpala at pp1.inet.fi
Thu May 22 21:01:17 CEST 2008


On Thu, 2008-05-22 at 17:21 +0200, Reimar Döffinger wrote:
> since it causes troubles to no end with standard make versions (in my
> case the MinGW make completely ignores the rules, and the linux one can
> not do parallel make), I propose attached patch.

I'd guess no version of Make recognizes the submake use in the current
Makefile automatically and so -j will not work for the recursive calls
on any machine. Adding a '+' to the command to explicitly flag it (as
the warning message suggests) works though.

> Maybe there is some subtle reason why it is not as good, then say so.
> Otherwise I will apply in a few days, because I'm really not in the mood
> to hut down a working make version for all of my PCs/OSs.

I'm not fluent enough in Make syntax to verify its correctness just by
reading it, but it seems to work. Given that -j probably doesn't work
properly on any system now I think there's no need to be overly careful
about changing it.




More information about the MPlayer-dev-eng mailing list