[MPlayer-dev-eng] [PATCH] Color SPU rendering

[Reimar Döffinger]

On Tue, Jan 29, 2008 at 11:40:04PM +0100, Ötvös Attila wrote:
> 2008. január 29. 23.20 dátummal Reimar Döffinger ezt írta:
> > Well, there is not really anything really libvo specific in these
> > patches.
> > Also the biggest questions about it are:
> > 1) How is this supposed to compile at all? It uses some dp variable that is
> > not declared at all.
> > 2) What is that VOCTRL_GUISUPPORT supposed to do? I can't see how the
> > return value is supposed to be useful in any way.
> 
> 1, call VOCTRL_COLOROSD_SUPPORT
> if return VO_TRUE:
> 
> call VOCTRL_QUERY_FORMAT -> set color spu type: 
> YUV (eg: IMGFMT_YV12, IMGFMT_I420, ...), 
> YUY, 
> RGB, 
> BGR (IMGFMT_BGR32, IMGFMT_BGR24, ...)

But VOCTRL_QUERY_FORMAT returns the colour formats supported for the main
picture, there is simply no reason why this should be related in any way
with what is supported for the OSD!
In addition, you also sometimes have checks for the colour format in the
VOCTRL_COLOROSD_SUPPORT, why not just do it in one thing and use
VOCTRL_COLOROSD_SUPPORT as a kind of VOCTRL_QUERY_FORMAT just for the
OSD?