[MPlayer-dev-eng] [PATCH] Color SPU rendering

[Reimar Döffinger]

Hello,
On Tue, Jan 29, 2008 at 09:15:27PM +0100, Benjamin Zores wrote:
> Benjamin Zores a écrit :
> > On Jan 28, 2008 11:07 AM, Ötvös Attila <oattila at chello.hu> wrote:
> >> Ezzel a dátummal: Sunday 27 January 2008 12.21.00 Benjamin Zores ezt írta:
> >> Hi Benjamin Zores!
> >>> In an attempt to start the color spu patchset for dvdnav, here's a first
> >>> patch.
> >>>
> >>> It adds a new VO control that will be used to ask each vo which
> >>> colorspace it can use to render SPUs.
> >>> Next patch will implement this VOCTRL for each vo driver.
> >> I make color SPU patchset.
> >>
> >> This patchs support color spu in vo's (VOCTRL_COLOROSD_SUPPORT and draw U,V
> >> planes if need/available).
> > 
> > Who has some good knowledge of libvo/ to review these patches ?
> 
> Same player shoots again ...
> No one's there with enough knowledge of libvo internals ?

Well, there is not really anything really libvo specific in these
patches.
Also the biggest questions about it are:
1) How is this supposed to compile at all? It uses some dp variable that is
not declared at all.
2) What is that VOCTRL_GUISUPPORT supposed to do? I can't see how the
return value is supposed to be useful in any way.