[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

Benjamin Zores ben at geexbox.org
Fri Jan 25 23:49:22 CET 2008


Ötvös Attila a écrit :
> Ezzel a dátummal: Friday 25 January 2008 20.51.47 Benjamin Zores ezt írta:
>> Reimar Döffinger a écrit :
>>> Note that this is only a very quick review, I have not truly understood
>>> even half of the code...
>> Attached an updated patch.
>> This is much more likely to be understood.
>>
>> I've split many functions in mplayer.c and remove some parts of code
>> that seemed to be unnecessary (as it works fine without them).
>> I've also removed all the libmpeg2 hacks that I really found ugly.
>>
>> Please review and comment.
>>
>> PS: If you intend to test for real-use, always do -vc=ffmpeg12
>>
>> Ben
> 
> Hi Ben!
> 
> I add still pts handle.

Btw, this part of the patch used to be in the _post() function of your 
previous patch (now called save_smpi) and it's now in your _pre() 
function (now called restore_smpi()).

Is it intended ?
As I can't reproduce the need, I have to trust you on this so I have to 
be sure.

Ben



More information about the MPlayer-dev-eng mailing list