[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Benjamin Zores]

Uoti Urpala a écrit :
> On Sat, 2008-01-26 at 11:30 +0100, Benjamin Zores wrote:
>> Final patch attached.
> 
> My opinion is still the same as what I said on IRC. The right way to
> implement still frame handling would not be to add a dvdnav-specific
> hack like this but to improve MPlayer's frame handling in general. Most
> of the code in this patch will almost certainly need to be ripped out
> when more general improvements are done. I don't expect you to fix
> MPlayer's more general infrastructure and I'm currently working on
> something else myself, so this patch may be the only way dvdnav support
> can in practice get added at the moment (and it's probably a desired
> feature); but I'm still not exactly happy about piling up more hacks
> that I'll have to clean up in the future.

We agree on that.
This is definitely not the best way to do.
I'd like to have a more generic way that will also enable playback of 
plain images as a video (i.e. use MPlayer as an image viewer) but right 
now, this is needed for dvdnav support to evolve so I'm gonna apply it.

We'll change this to a more generic (and much better) way some day in 
the future. That's also the reason why I've tried to minimize the hacks 
and removed the libmpeg2 ones.

Ben