[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible

[Uoti Urpala]

On Tue, 2008-01-15 at 12:06 +0100, Guillaume LECERF wrote:
> 2008/1/15, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Which in this case is a bit annoying since the indentation of the
> > function was completely changed and even a commented-out line was
> > removed, which is completely unrelated to the subject of this patch...
> 
> OK, I applied all your suggestions, here is the new version.

Diffing it against font_load_ft.c, making the patch 1304 lines long, was
one suggestion you would have been better off not applying... That
suggestion was not such a good idea, in case it wasn't clear from the
earlier thread already.

Anyway the basic functionality of the patch looks OK (that was already
the case with the previous version you sent). The main question I see is
whether creating a new file is the most appropriate place for the
function. I haven't tried checking for other potential files yet.

You said earlier that you're doing some kind of "font handling
overview". Do you intend to use the newly created file for some other
font-related functionality too?