[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible

[Guillaume LECERF]

2008/1/15, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> Diffing it against font_load_ft.c, making the patch 1304 lines long, was
> one suggestion you would have been better off not applying... That
> suggestion was not such a good idea, in case it wasn't clear from the
> earlier thread already.

I fully agree with you, I first followed the advice but then forgot to
revert it before generating the patch.

> Anyway the basic functionality of the patch looks OK (that was already
> the case with the previous version you sent). The main question I see is
> whether creating a new file is the most appropriate place for the
> function. I haven't tried checking for other potential files yet.

We need to put free_font_desc() in a file that is only compiled when
bitmap or FreeType font support is enabled, so it is the simplest
solution I found.

> You said earlier that you're doing some kind of "font handling
> overview". Do you intend to use the newly created file for some other
> font-related functionality too?

I'm trying to decouple font handling into osd font, sub font and menu
font, to be able to handle font scale independently, and btw resolve
an annoying sub scale bug which scales menu font with sub font.

-- 
Guillaume LECERF
GeeXboX developer - www.geexbox.org