[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible

[Uoti Urpala]

On Mon, 2008-01-14 at 19:06 +0000, Carl Eugen Hoyos wrote:
> Guillaume LECERF <foxcore <at> gmail.com> writes:
> > What do you think of this one ?
> 
> It's usually necessary to svn cp a file to produce an acceptable patch in a
> situation like this. Do
> mv libvo/font_util.c backup
> svn cp libvo/font_load_ft.c libvo/font_util.c
> mv backup libvo/font_util.c
> 
> After removing possible unnecessary cosmetic changes from font_util.c, resend
> patch.

font_load_ft.c is 1172 lines long. If you want to verify how close the
function is to the original make a diff yourself. Do not ask the patch
submitter to send patches with 1000+ superfluous lines to the list for
that purpose.

In this case the patch was submitted in a perfectly reasonable manner.
Making requests like the above (and not even worded as a request but in
an unfriendly manner implying the original was "unacceptable") is a
situation where I think Balatoni Denes's recent complaints about patch
reviewing do apply.