[MPlayer-dev-eng] [PATCH] move free_font_desc() to font_load.h and use it everywhere it's possible

Carl Eugen Hoyos cehoyos at ag.or.at
Mon Jan 14 20:06:31 CET 2008


Hi!

Guillaume LECERF <foxcore <at> gmail.com> writes:

> 2008/1/11, Aurelien Jacobs <aurel <at> gnuage.org>:
> > But this don't avoid code duplication.
> > I see no reason to have this function inlined, and thus, no reason to
> > have it defined in a header. IMO you should move this function in
> > a .c file.
> 
> What do you think of this one ?

It's usually necessary to svn cp a file to produce an acceptable patch in a
situation like this. Do
mv libvo/font_util.c backup
svn cp libvo/font_load_ft.c libvo/font_util.c
mv backup libvo/font_util.c

After removing possible unnecessary cosmetic changes from font_util.c, resend
patch.

Carl Eugen




More information about the MPlayer-dev-eng mailing list