[MPlayer-dev-eng] [PATCH] demuxer-independent attachments

[Uoti Urpala]

On Tue, 2008-01-08 at 11:42 +0100, Nico Sabbi wrote:
> Il Tuesday 08 January 2008 11:35:49 Uoti Urpala ha scritto:
> > Which cleanup code are you talking about? The only cleanup I see in
> > this patch is freeing the attachment data, and having that in the
> > demuxer layer should be perfectly OK - nothing codec-specific about
> > it.
> 
> I was talking generically about init() and uninit() functions

Well I still don't see what initialization and uninitialization your
comment would apply to here. Demuxer layer sets up the attachment data
and frees it when the demuxer is destroyed. Higher level code uses that
data and deals with the semantics of it. Looks fine to me.