[MPlayer-dev-eng] [PATCH] demuxer-independent attachments

[Nico Sabbi]

Il Tuesday 08 January 2008 11:35:49 Uoti Urpala ha scritto:
> On Tue, 2008-01-08 at 11:24 +0100, Nico Sabbi wrote:
> > Il Tuesday 08 January 2008 10:52:47 Evgeniy Stepanov ha scritto:
> > > On Tuesday 08 January 2008 11:47:51 Nico Sabbi wrote:
> > > > I don't like it even remotely: the demuxer layer has nothing
> > > > to do with ass!
> > >
> > > The chunk with ass_add_font could be moved to mplayer.c, right
> > > after the demuxer is opened. It makes sense because it deals
> > > with a global (per-file, to be exact) object.
> >
> > it would be even worse: initialization and cleanup can't be split
> > in different files.
>
> Which cleanup code are you talking about? The only cleanup I see in
> this patch is freeing the attachment data, and having that in the
> demuxer layer should be perfectly OK - nothing codec-specific about
> it.
>

I was talking generically about init() and uninit() functions