[MPlayer-dev-eng] [PATCH] demuxer-independent sub and audio track selection

Rich Felker dalias at aerifal.cx
Mon Feb 25 21:32:28 CET 2008


On Mon, Feb 25, 2008 at 09:09:14PM +0200, Uoti Urpala wrote:
> > The corollary being that not strongly discouraging strncpy tends to mean more
> > work for both patch submitters and reviewers.
> 
> "Remember to ensure 0-termination" is IMO simpler to remember than
> "remember to use av_strlcpy for MPlayer-specific code". And I think
> there aren't that many patches which would use strncpy multiple times.

I don't think anyone was saying there should be a policy of requiring
av_strlcpy/cat but rather a policy forbidding or at least strongly
discouraging strn* functions. These functions are NOT for working with
C-style null-terminated strings but for fixed-width textual database
fields like the crap that brought about the 'Y2K' crisis..

Rich



More information about the MPlayer-dev-eng mailing list