[MPlayer-dev-eng] [PATCH] mmap support for OS/2

[Diego Biurrun]

On Mon, Feb 25, 2008 at 10:41:08AM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>> On Mon, Feb 25, 2008 at 01:12:56AM +0900, KO Myung-Hun wrote:
>>   
>>> This patch add a simple mmap support for OS/2.
>>>
>>> --- osdep/mmap.h	(revision 0)
>>> +++ osdep/mmap.h	(revision 0)
>>> @@ -0,0 +1,73 @@
>>> +
>>> +/* MAP_FAILED is defined in config.h */
>>> +#if 0
>>> +/*
>>> + * Error return from mmap()
>>> + */
>>> +#ifndef MAP_FAILED
>>> +#define MAP_FAILED  ((void *)-1)
>>> +#endif
>>> +#endif
>>
>> I don't like #if 0 code...
>
> Instead, commented it out.

That's no better.  I meant that I don't like committing code that is off
by default.  Why is it there in the first place?

Diego