[MPlayer-dev-eng] [PATCH] mmap support for OS/2

[KO Myung-Hun]

Hi/2.


Diego Biurrun wrote:
> On Mon, Feb 25, 2008 at 01:12:56AM +0900, KO Myung-Hun wrote:
>   
>> This patch add a simple mmap support for OS/2.
>>
>> --- osdep/mmap.h	(revision 0)
>> +++ osdep/mmap.h	(revision 0)
>> @@ -0,0 +1,73 @@
>> +
>> +#ifndef MMAP_H
>> +#define MMAP_H
>>     
>
> MPLAYER_ prefix please.
>
>   

Ok.

>> +#ifdef __cplusplus
>> +extern "C" {
>> +#endif
>>     
>
> IMO unnecessary and ugly.
>
>   

Removed it.

>> +/* MAP_FAILED is defined in config.h */
>> +#if 0
>> +/*
>> + * Error return from mmap()
>> + */
>> +#ifndef MAP_FAILED
>> +#define MAP_FAILED  ((void *)-1)
>> +#endif
>> +#endif
>>     
>
> I don't like #if 0 code...
>
>   

Instead, commented it out.

>> +#endif
>>     
>
> #endif /* MPLAYER_MMAP_H */
>
>   

Ok.

>> --- osdep/Makefile	(revision 26091)
>> +++ osdep/Makefile	(working copy)
>> @@ -27,8 +27,16 @@
>>  ifeq ($(TARGET_OS),OS/2)
>>  getch = getch2-os2.c
>>  endif
>> +
>> +ifneq ($(HAVE_SYS_MMAN_H),yes)
>> +ifeq ($(TARGET_OS),OS/2)
>> +mmap = mmap-os2.c
>> +endif
>> +endif
>>     
>
> Merge the two TARGET_OS OS/2 sections.
>
>   

Ok.

I've attached a new patch as your suggestion.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.8
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mmap.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080225/54c04ec3/attachment.txt>