[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

[Reimar Döffinger]

On Wed, Feb 20, 2008 at 11:27:12PM +0900, KO Myung-Hun wrote:
> Reimar Döffinger wrote:
> > On Wed, Feb 20, 2008 at 09:20:35PM +0900, KO Myung-Hun wrote:
> >>> I do not like this renaming at all, this is still code that is full of
> >>> Windows-API stuff. Sure it is used for OS/2 as well, but is is still the
> >>> Windows API it uses, so the previous name still seems more correct.
> >>>   
> >>>       
> >> I agree with you. But it seems that Alban and Diego want it.
> >>     
> >
> > Well, with the reasoning in that mail it actually makes sense.
> > I would slightly prefer if whoever applies this first renames
> > the mp_input_win32_slave_cmd_func and then applies the rest, but it's
> > not too important.
> >   
> 
> It's important to me as patch committer. Because I should follow the 
> advice of maintainers and maintainers should coincide in opinion so that 
> the patch can be accepted. BTW if they have different opinions from one 
> another, it is too hard that I decide to follow which opinion.

No, firstly you are the patch _submitter_, the committer is the one who
will apply it. Thus what I suggested above is not relevant to you.
If we have different opinions that like is this case sometimes is just
because we did not properly read all further mails and miss some
arguments.

> So do you have a objection to the patch ?

Sorry that my previous mail was unclear.
No, I do not have any objections (though I looked only quickly at the
OS/2 code).
My suggestions were only for the way it is applied.

Greetings,
Reimar Döffinger