[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

[KO Myung-Hun]

Hi/2.

Reimar Döffinger wrote:
> Hello,
> On Wed, Feb 20, 2008 at 09:20:35PM +0900, KO Myung-Hun wrote:
>   
>>> I do not like this renaming at all, this is still code that is full of
>>> Windows-API stuff. Sure it is used for OS/2 as well, but is is still the
>>> Windows API it uses, so the previous name still seems more correct.
>>>   
>>>       
>> I agree with you. But it seems that Alban and Diego want it.
>>     
>
> Well, with the reasoning in that mail it actually makes sense.
> I would slightly prefer if whoever applies this first renames
> the mp_input_win32_slave_cmd_func and then applies the rest, but it's
> not too important.
>   

It's important to me as patch committer. Because I should follow the 
advice of maintainers and maintainers should coincide in opinion so that 
the patch can be accepted. BTW if they have different opinions from one 
another, it is too hard that I decide to follow which opinion.

So do you have a objection to the patch ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.8
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr