[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

[KO Myung-Hun]

Hi/2.


Reimar Döffinger wrote:
> Hello,
> On Wed, Feb 20, 2008 at 06:28:55PM +0900, KO Myung-Hun wrote:
>   
>> Index: osdep/getch2-win.c
>> ===================================================================
>> --- osdep/getch2-win.c	(revision 26012)
>> +++ osdep/getch2-win.c	(working copy)
>> @@ -13,7 +13,7 @@
>>  // HACK, stdin is used as something else below
>>  #undef stdin
>>  
>> -int mp_input_win32_slave_cmd_func(int fd,char* dest,int size){
>> +int mp_input_slave_cmd_func(int fd,char* dest,int size){
>>    DWORD retval;
>>    HANDLE stdin = GetStdHandle(STD_INPUT_HANDLE);
>>    if(!PeekNamedPipe(stdin, NULL, size, &retval, NULL, NULL) || !retval){
>>     
>
> I do not like this renaming at all, this is still code that is full of
> Windows-API stuff. Sure it is used for OS/2 as well, but is is still the
> Windows API it uses, so the previous name still seems more correct.
>   

I agree with you. But it seems that Alban and Diego want it.

> Add a comment that it also handles OS/2 if you want.
> Or if you really want to rename if make it win32_os2...
>
>   

I've added a comment to the patch.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.8
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: getch2-os2.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080220/a457b2e1/attachment.txt>