[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

[Reimar Döffinger]

Hello,
On Wed, Feb 20, 2008 at 06:28:55PM +0900, KO Myung-Hun wrote:
> Index: osdep/getch2-win.c
> ===================================================================
> --- osdep/getch2-win.c	(revision 26012)
> +++ osdep/getch2-win.c	(working copy)
> @@ -13,7 +13,7 @@
>  // HACK, stdin is used as something else below
>  #undef stdin
>  
> -int mp_input_win32_slave_cmd_func(int fd,char* dest,int size){
> +int mp_input_slave_cmd_func(int fd,char* dest,int size){
>    DWORD retval;
>    HANDLE stdin = GetStdHandle(STD_INPUT_HANDLE);
>    if(!PeekNamedPipe(stdin, NULL, size, &retval, NULL, NULL) || !retval){

I do not like this renaming at all, this is still code that is full of
Windows-API stuff. Sure it is used for OS/2 as well, but is is still the
Windows API it uses, so the previous name still seems more correct.
Add a comment that it also handles OS/2 if you want.
Or if you really want to rename if make it win32_os2...

Greetings,
Reimar Döffinger