[MPlayer-dev-eng] A note on (security) patches

Diego Biurrun diego at biurrun.de
Mon Feb 11 09:31:12 CET 2008


Hey, I just noticed that the current slew of (security) patches we
published have headers like

Index: stream_cddb.c
===================================================================
--- stream_cddb.c	(revision 24724)
+++ stream_cddb.c	(working copy)

This is no good.  It should be possible to apply patches from the root
of the source tree without having to know which directory the relevant
files are hidden in.

I already consider patches sent to this mailing list a nuisance if I
have to change directory somewhere to apply them.  But we developers
know where files are in our source tree.  This does not necessarily
apply to people who download security fixes and apply them to their
source tarballs.

I have fixed all patches that we have on mphq, but please bear this in
mind for the future.

Diego



More information about the MPlayer-dev-eng mailing list