[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Chris Roccati]

On 15 Dec 2008, at 22:24 , Guillaume POIRIER wrote:
> I'm happy to see someone finally reacting to that change. The thing
> is: I don't think I ever used Mplayer's Finder args feature.
> It's not even documented how it's supposed to work, and what to expect
> from it!!!

The finder args feature was added by me long ago, in a (now  
forgotten) quest of providing mplayer with a mac-like interface. The  
code provided in osdep/macos_finder_args.c allows the executable to  
be wrapped inside an application bundle and to receive the files to  
be played via the finder, enabling the use of the (more or less) bare  
mplayer as a default application for video files.

> Could you give me a test case so that I can check the behavior before
> and after the patch?

You need to wrap the executable in an application bundle, with an  
Info.plist defining atleast one supported file type; then you will be  
able to open that file type with mplayer using the "Open With"  
context menu.

If you remove QuitApplicationEventLoop() the mplayer icon (whatever  
you provided in the application bundle) will appear in the dock, but  
mplayer will start playing the file after selecting "Quit MPlayer"  
from the "MPlayer" menu. If you leave the code as-is, the playback  
will start (as expected) immediately.

If you need it, I can directly send you the application bundle with  
everything but the mplayer executable.

> In any case, something will have to be made about that piece of code,
> since it is not 64-bits friendly as is.

I will check what the options are, but I'm still using MacOS 10.4.x  
(with a powermac G5).