[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

Guillaume POIRIER poirierg at gmail.com
Mon Dec 15 22:24:22 CET 2008


Hello,

On Mon, Dec 15, 2008 at 9:59 PM, Dario Roccati <roccati at pobox.com> wrote:
>
> On 14 Dec 2008, at 23:57 , Guillaume POIRIER wrote:
>> I don't see further reason to not remove that call now.
>
> If you remove that call, macosx_finder_args.c will simply stop working:
>
> the QuitApplicationEventLoop() call in AppleEventHandlerProc is there
> to stop the RunApplicationEventLoop() in macos_finder_args(),
> allowing the function to return the file list that was provided by
> the finder to the application.

I'm happy to see someone finally reacting to that change. The thing
is: I don't think I ever used Mplayer's Finder args feature.
It's not even documented how it's supposed to work, and what to expect
from it!!!

Could you give me a test case so that I can check the behavior before
and after the patch?

In any case, something will have to be made about that piece of code,
since it is not 64-bits friendly as is.

Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Jay London  - "I was going to buy a book on hair loss, but the pages
kept falling out."



More information about the MPlayer-dev-eng mailing list