[MPlayer-dev-eng] Direct3D OSD discussion

[Reimar Döffinger]

Hello,
On Mon, Dec 08, 2008 at 11:38:58AM +0000, Jim Hauxwell wrote:
> I think it will suffer from the same problem that the original patch
> has.  The texture will be stretched when the aspect is changed.

It should behave exactly the same as your patch, there is just an
additional fix for the case vo_dwidth > max_texture_width (which is
the only case where priv->osd_width != vo_dwidth)
(same if vo_dheight > max_texture_height).
Of course I may have done something stupid somewhere.

> I'm also confused as to why the intrinsics were dropped, doesn't MPlayer
> stipulate to compile on gcc only?  This is not an issue, just I would
> like to know for future.

No, certainly not! Though _currently_ it only works with gcc on Windows
the long term goal is to work with any C99 compliant compiler (which
unfortunately means probably never with the Microsoft compiler).
For adequate performance support for gcc-style inline-assembly is
required, too.

> I would also like to know why there is a second draw in the
> render_d3d_frame which only has enough vertices for a single triangle?
> Are you trying to redraw the OSD?  If so, why?

Sorry, debugging code. Wine renders nothing at all unless at least one
primitive is drawn as well.
Should be fixed in attached patch.
And yes I should probably try to find a Windows-PC to properly test.

Greetings,
Reimar Döffinger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: d3d_osd.diff
Type: text/x-diff
Size: 15261 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081208/52f5a53e/attachment.diff>