[MPlayer-dev-eng] [PATCH] libvo: set PBaseSize in SizeHints

[Reimar Döffinger]

On Fri, Dec 05, 2008 at 07:12:19PM +0100, Bert Wesarg wrote:
> from ICCCM 4.1.2.3:
> 
>   width = base_width + (i × width_inc)
>   height = base_height + (j × height_inc)
> 
>   Window managers are encouraged to use i and j instead of width and height
>   in reporting window sizes to users. If a base size is not provided, the
>   minimum size is to be used in its place and vice versa.
> 
> But mplayer sets the PMinSize size to 4x4 in x11_common.c and no
> PBaseSize, so the WM takes the PMinSize as PBaseSize and reports a
> size minus 4x4. Which is just plain wrong. The WM behaves conform to
> the ICCCM so mplayer needs to fix this.

"plain wrong"? As I read it you don't like that your window manager
tells you the window size relative to the minimum and would prefer
absolute values, and like this you make MPlayer force your window
manager to do that. But that does not make the previous behaviour wrong.
In addition, the obvious question is if what you suggest makes most
sense, because what I would consider the "base size" is the unscaled
(but aspect-adjusted) size of the video, why not set that instead of 0?

Greetings,
Reimar Döffinger