[MPlayer-dev-eng] [PATCH] libvo: set PBaseSize in SizeHints

Bert Wesarg bert.wesarg at googlemail.com
Fri Dec 5 19:12:19 CET 2008


Hi all,

from ICCCM 4.1.2.3:

  width = base_width + (i × width_inc)
  height = base_height + (j × height_inc)

  Window managers are encouraged to use i and j instead of width and height
  in reporting window sizes to users. If a base size is not provided, the
  minimum size is to be used in its place and vice versa.

But mplayer sets the PMinSize size to 4x4 in x11_common.c and no
PBaseSize, so the WM takes the PMinSize as PBaseSize and reports a
size minus 4x4. Which is just plain wrong. The WM behaves conform to
the ICCCM so mplayer needs to fix this.

Regards
Bert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: basesize.patch
Type: text/x-diff
Size: 862 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081205/62d13820/attachment.patch>


More information about the MPlayer-dev-eng mailing list