[MPlayer-dev-eng] [PATCH] handle vobsub idx information from lavf demuxer

[Reimar Döffinger]

Hello,

Sorry for being nit-picky, but...

On Thu, Aug 28, 2008 at 03:45:54PM +0200, Aurelien Jacobs wrote:
> +static void lavf_parse_idx(sh_sub_t* sh) {
> +    char *ptr = sh->extradata;

Wouldn't it be better to use const here?

> +    do {
> +        if (!strncmp(ptr, "size:", 5))
> +            sscanf(ptr, "size: %dx%d", &sh->width, &sh->height);

Also, I have some doubts it is okay to assume that extradata is
0-terminated.
Unfortunately changing it would be an API change, but am I the only one
who thinks this extradata format is not just a bit but actually
_extremely_ stupid?

Greetings,
Reimar Döffinger