[MPlayer-dev-eng] [PATCH] handle vobsub idx information from lavf demuxer

[Aurelien Jacobs]

Aurelien Jacobs wrote:

> Reimar Döffinger wrote:
> 
> > On Thu, Aug 28, 2008 at 03:41:57AM +0200, Aurelien Jacobs wrote:
> > > Currently, the lavf demuxer is able to extract vobsub track, and puts some
> > > idx-like text in the extradata. But this extradata is not parsed anywhere.
> > > This results in wrongly scaled subtitles or wrong palette.
> > > Attached patch ensure this extradata is parsed and used.
> > 
> > I do not at all like that it is done in mplayer.c, that means it will
> > still not work in mencoder and whoever (if anyone) will fix it will
> > most likely just copy-and-paste.
> > Can't that be done in demux_lavf.c?
> 
> Sure, it can. I first thought that it should be done in a more central
> place so that it can eventually benefit other demuxers. But now that I
> think about it, the only demuxer we care about is lavf. All other
> demuxers should be removed, sooner or later.
> So putting this code in demux_lavf.c seems fine to me.
> See attached patch.

I will apply this soon if no one disagree.

Aurel