[MPlayer-dev-eng] vo_gl PBO patch ..

[Sven Gothel]

On Wednesday 30 April 2008 12:36:40 Reimar Döffinger wrote:
> On Tue, Apr 29, 2008 at 01:58:23PM -0600, Sven Gothel wrote:
> > On Tuesday 29 April 2008 13:52:02 Sven Gothel wrote:
> > > > > But the _pic variants will handle stride-conversion for you.
> > > > > 
> > > > 
> > > > I see .. great, I will double check this - thanks.
> > > > 
> > > > So, just drop 'version 4', which I just have send out ..
> > > 
> > > I will check this now, ...
> > 
> > Well, it will 'just' boil down to use 'memcpy'.
> > The 'old' style of manual optimization is obsolete,
> > I have written about this in the ML as well.
> 
> Huh? Written what?
> 
> > The new gcc (>=4.1 ?) will do this for us ..
> 
> Currently, even gcc 2.95 is among the supported compilers, and ignoring
> gcc 3.4 certainly is not acceptable. Also relying on a compiler to do
> critical optimizations in my experience has always proven very foolish,
> compilers are simply not reliable when it comes to optimization.
> But all this is besides the point, I did not mention the memcpy_pic
> function for performance reasons but to simplify code, this is a memcpy
> function that already does all the stride handling, why duplicating the
> code again?

Ok, ack.

In one configurable case, we have a single memcpy,
where the GPU shall handle the stride,
which shall be the fasted way possible.
The single memcpy call is appropriate here.

In the other configurable case, multiple memcpy,
well, ok .. we may can use the memcpy_pic and drop this little
self written loop.

> 
> And please do not CC me when answering, I am subscribed to the list
> after all.

Aye Aye :)

Cheers, Sven
> 
> Greetings,
> Reimar Döffinger
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 



-- 
health & wealth
mailto:sgothel at jausoft.com ; www  : http://www.jausoft.ca ; pgp: http://www.jausoft.com/gpg/
land : +1 (780) 637 3842 ; cell: +1 (780) 952 4481
Timezone MST: EST-2, UTC-7, CET-8 ; MDT: EDT-2, UTC-6, CEDT-8