[MPlayer-dev-eng] vo_gl PBO patch ..

[Reimar Döffinger]

On Tue, Apr 29, 2008 at 01:58:23PM -0600, Sven Gothel wrote:
> On Tuesday 29 April 2008 13:52:02 Sven Gothel wrote:
> > > > But the _pic variants will handle stride-conversion for you.
> > > > 
> > > 
> > > I see .. great, I will double check this - thanks.
> > > 
> > > So, just drop 'version 4', which I just have send out ..
> > 
> > I will check this now, ...
> 
> Well, it will 'just' boil down to use 'memcpy'.
> The 'old' style of manual optimization is obsolete,
> I have written about this in the ML as well.

Huh? Written what?

> The new gcc (>=4.1 ?) will do this for us ..

Currently, even gcc 2.95 is among the supported compilers, and ignoring
gcc 3.4 certainly is not acceptable. Also relying on a compiler to do
critical optimizations in my experience has always proven very foolish,
compilers are simply not reliable when it comes to optimization.
But all this is besides the point, I did not mention the memcpy_pic
function for performance reasons but to simplify code, this is a memcpy
function that already does all the stride handling, why duplicating the
code again?

And please do not CC me when answering, I am subscribed to the list
after all.

Greetings,
Reimar Döffinger