[MPlayer-dev-eng] [PATCH] -noconfig option

[Andrew Savchenko]

Hi,

On Monday 14 April 2008 15:54, Alban Bedel wrote:
[...]
> > The first patch is a bugfix for mencoder: system-wide config
> > file reading.
>
> Applied with a fix, declaration are not allowed in the middle of
> code blocks (it break gcc 2.95.3).

Yes, I must remember at some point that mplayer must be compatible 
with gcc-2.95...

> > The second patch is -noconfig option itself, requires 1st
> > path.
>
> Applied with a few fixes: preparsed option _must_ be global 

I agree with this.

> and the noconfig_all function can be made static.

Well, I do not object against this. But what is the reason to make 
it static? It has no arguments neither variable declarations, thus 
I can see no benefits nor disadvantages of making it static.

Sincerely,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080415/d996c0c3/attachment.pgp>