[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Rich Felker]

On Sat, Sep 29, 2007 at 06:42:34AM -0400, Ergzay wrote:
> 
> On 2007/09/29, at 3:14, Rich Felker wrote:
> 
> > On Fri, Sep 28, 2007 at 11:58:37PM -0400, Ergzay wrote:
>   <snip>
> 
> I wasn't referring to patches with bugs. I was referring to the the 
> fact on what you said on your earlier comment about "mac os x specific 
> features." Rich, noticed you are almost always harsh with most people 
> and their patches. The rest of the devels manage to comment on people's 
> patches without insulting them, but you don't seem to do that that 
> often.

Actually I make all kinds of comments on patches, often technical and
constructive ones. But when patches are fundamentally bad I’m not
afraid to say so.

> Refusing unclean patches is fine, but refusing it just because you feel 
> "huge bloated additions to the codebase to support trivial 
> Apple-specific features are not welcome" is silly. If that's what the 
> code requires then so be it.

How come no other input device has ever required huge invasive changes
to support? Either this patch is just badly written and not doing
things right, or Apple’s API is nonsense. Moreover the whole idea of
delaying the processing of a first click in order to make sure it’s
not a doubleclick is stupid and counterintuitive. In every other
application I’ve ever seen, a doubleclick functions as additional
behavior on top of what a single click already did...

I’ve also been told (out-of-band) by others reading this patch that
either the API is horribly broken or else the patch author is not
using it right. Either would be a perfectly good reason for rejecting
the patch, but if it’s fixable I’d be happy to see it fixed and
included. However I will not be happy to see more broken stuff
included in MPlayer. We already have way too much broken stuff...

> There are a lot of apple users with newer 
> macs. I love the fact that apple remote control support has finally 
> been added. It was long overdue (as well as many other features that 
> mplayer has fallen behind in, not just mac os x related).

I don’t need to hear this crap again. It’s what fruit fanboys always
say to try to make their ‘special needs’ sound important.

Rich