[MPlayer-dev-eng] [PATCH] Apple Remote support double click

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Sep 29 13:18:43 CEST 2007


Hello,
On Sat, Sep 29, 2007 at 06:42:34AM -0400, Ergzay wrote:
[...]
> Refusing unclean patches is fine, but refusing it just because you feel 
> "huge bloated additions to the codebase to support trivial 
> Apple-specific features are not welcome" is silly. If that's what the 
> code requires then so be it.

Rich, very much like me, probably thinks that it is very, very unlikely
that it is required to be so convoluted. Though improving it might
require dropping some "features", like not delaying click events to see
if they are part of a double click (another reason for this is that a
few people explicitly didn't want this for mouse double click because it
delays the events too much) or seeing if the even timestamps really are
necessary (I'd normally expect the jitter introduced by ignoring them
not more than 30 ms which seems in the acceptable range) etc.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list