[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Ulion]

2007/9/22, Luca Barbato <lu_zero at gentoo.org>:
> Ulion wrote:
> > I known what you mean. But there are some reason I did not use mp_fifo:
> > 1. First of all, the mp_fifo has no event timestamp, check doubleclick
> > highly depends on the timestamps of event, specially Apple Remote
> > (which got events by a loop check, use the time we got the event is
> > not accurate.).
>
> Hm what about extending it?

Yes, we can extend mp_fifo to support event timestamp. But this is not
the only reason current not using mp_fiifo.

>
> > 2. mp_fifo's doubleclick check code now is only used for mouse
> > doubleclick check. It's there mainly because each vo module got mouse
> > event by different method, for a common way to get doubleclick event
> > from different vo modules, mp_fifo was introduced.
>
> see 1

mp_fifo is for common perpose of mouse doubleclick check. But apple
remote doubleclick has different perpose for doubleclick checking, see
3.

>
> > 3. mp_fifo will send out all events even if it's one click of a
> > doubleclick event. This is not we expected. If it's a doubleclick, we
> > need not any single click event, these need codes to delay event and
> > resend event out depends whether it's a doubleclick. Since Apple
> > Remote currently only for apple darwin platform, it's not worth to
> > make mp_fifo so complex, by now keep the ar-doubleclick code only in
> > ar.c is a good choice.
>
> lirc doesn't support this?
>

You mean apple remote? or doubleclick?
If apple remote, it is discussed last month when the initial apple
remote code was reviewed, as I remember. If you mean doubleclick, I
have no idea, since I'm working on improving the apple remote native
code that works more simple and accurate than lirc, at lease it will
work fine for any fresh user without config.

>
> comment on the patch:
>
> a- avoid LOOOONG lines 79 cols at most.

I re-checked the patch, most lines longer than 80 columns is msg
print, which I have no idea how to break the print message without add
spaces into the print result, any idea? Other few lines longer than 80
cols were caused by the longer api name and some fullmeaning variable
which has a little longer name, I will try harder to keep the line
width.

> b- remove the debug clutter

You mean the define TEST part or the mp_msg debug output?

> c- think about extending mp_fifo to support this.

If some one can finished that in mp_fifo, I'd like to use it and
remove ar doubleclick code. I have no reason to put these code into
mp_fifo since this part of code is only used by apple remote input
module.

> Luca Barbato
>
> Gentoo/linux Gentoo/PPC
> http://dev.gentoo.org/~lu_zero

Thank you for the reply.

-- 
Ulion