[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Luca Barbato]

Ulion wrote:
> I known what you mean. But there are some reason I did not use mp_fifo:
> 1. First of all, the mp_fifo has no event timestamp, check doubleclick
> highly depends on the timestamps of event, specially Apple Remote
> (which got events by a loop check, use the time we got the event is
> not accurate.).

Hm what about extending it?

> 2. mp_fifo's doubleclick check code now is only used for mouse
> doubleclick check. It's there mainly because each vo module got mouse
> event by different method, for a common way to get doubleclick event
> from different vo modules, mp_fifo was introduced.

see 1

> 3. mp_fifo will send out all events even if it's one click of a
> doubleclick event. This is not we expected. If it's a doubleclick, we
> need not any single click event, these need codes to delay event and
> resend event out depends whether it's a doubleclick. Since Apple
> Remote currently only for apple darwin platform, it's not worth to
> make mp_fifo so complex, by now keep the ar-doubleclick code only in
> ar.c is a good choice.

lirc doesn't support this?


comment on the patch:

a- avoid LOOOONG lines 79 cols at most.
b- remove the debug clutter
c- think about extending mp_fifo to support this.

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero